-
Notifications
You must be signed in to change notification settings - Fork 17
[ON-HOLD] feat: Add some filetype guessing capabilities #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* fix: No error emssage dict recreation, all strings are static, so... * fix: Imports * fix: autopep8 formatting opinions * fix: Errors become consistent * fix: Stream closing error handling * fix: Stream error handling update * fix: Format * fix: Format 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great example of why I want most of the functionality tests in Rust instead of repeating them in every language. The appropriate level of testing in python should just be to validate that a file without an extension can be processed. The rest of the tests should be handled in Rust so that we don't need to duplicate them, and all the test files everywhere. Large test files slow down builds.
I'd prefer most of these test files to only live in one place. We may want to create a separate repo for them if they really need to be shared like this.
So hmmm, how do we proceed? Do you want me to remove the test files (and related tests for the mimetype guessing, then - aka the whole |
Let's put a pin in that for now - if the guessing moves down soon to the c2pa-rs Rust code SDK, we can heavily simplify that (by just adding the tests to verify the functionality). |
Uh oh!
There was an error while loading. Please reload this page.